Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Listen to trait changes on iOS 17+ #17528

Merged
merged 3 commits into from
Nov 27, 2024
Merged

feat: Listen to trait changes on iOS 17+ #17528

merged 3 commits into from
Nov 27, 2024

Conversation

MartinZikmund
Copy link
Member

@MartinZikmund MartinZikmund commented Jul 15, 2024 •
edited
Loading

GitHub Issue (If applicable): closes #17529

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@github-actions github-actions bot added the platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform label Jul 15, 2024
@MartinZikmund MartinZikmund enabled auto-merge July 15, 2024 12:08
@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17528/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17528/index.html

@MartinZikmund MartinZikmund changed the title feat: Listen to trat changes on iOS 17+ feat: Listen to trait changes on iOS 17+ Jul 15, 2024
@jeromelaban jeromelaban marked this pull request as draft July 26, 2024 18:42
auto-merge was automatically disabled July 26, 2024 18:42

Pull request was converted to draft

@MartinZikmund MartinZikmund force-pushed the dev/mazi/ios-traits-compat branch from cb52d10 to d851ac9 Compare November 23, 2024 06:56
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17528/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17528/index.html

@MartinZikmund MartinZikmund self-assigned this Nov 25, 2024
@MartinZikmund MartinZikmund force-pushed the dev/mazi/ios-traits-compat branch from d851ac9 to 4326360 Compare November 25, 2024 13:09
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17528/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17528/index.html

@MartinZikmund MartinZikmund marked this pull request as ready for review November 25, 2024 16:13
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17528/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17528/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 148365 has failed on Uno.UI - CI.

@MartinZikmund MartinZikmund force-pushed the dev/mazi/ios-traits-compat branch from 006e805 to e98f10b Compare November 26, 2024 13:19
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17528/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17528/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 148464 has failed on Uno.UI - CI.

@jeromelaban jeromelaban disabled auto-merge November 27, 2024 13:47
@jeromelaban
Copy link
Member

The build was fixed in a previous PR.

@jeromelaban jeromelaban merged commit f880d6d into master Nov 27, 2024
111 of 114 checks passed
@jeromelaban jeromelaban deleted the dev/mazi/ios-traits-compat branch November 27, 2024 13:47
@jeromelaban jeromelaban mentioned this pull request Dec 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramezgerges ramezgerges ramezgerges approved these changes

@jeromelaban jeromelaban jeromelaban approved these changes

Assignees

@MartinZikmund MartinZikmund

Labels
platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[iOS] TraitCollectionDidChange is deprecated in iOS 17+
4 participants
@MartinZikmund @unodevops @jeromelaban @ramezgerges