docs(dialogs): Fixed Link in dialogs.md documenation: Link to HowTo-ShowDialog was broken #18666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Link below c#-Markup was broken, did not do anything added the Link to the official wiki to HowTo-ShowDialog on plattform.uno. TODO: Add actual c#-markup How To to that article since its actually only including xaml markup support for that
jeromelaban
approved these changes
Nov 4, 2024
|
Congrats on your first pull-request! We ❤ the people who are involved in this project, and we’d love to pay it forward by sending you some swag. If you have any feedback (or ideas how to improve Uno as a open-source project) please open a feedback issue. |
|
@Mergifyio backport release/stable/5.5 |
✅ Backports have been created
|
3 tasks
jeromelaban
added a commit
that referenced
this pull request
Nov 4, 2024
…5.5/pr-18666 docs(dialogs): Fixed Link in dialogs.md documenation: Link to HowTo-ShowDialog was broken (backport #18666)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated the link-address to be now working as expected
GitHub Issue (If applicable): closes #
PR Type
What kind of change does this PR introduce?
What kind of change does this PR introduce?
What is the current behavior?
Link directs to no where, not useable
What is the new behavior?
fixed the Link-Address to the official wiki to HowTo-ShowDialog on plattform.uno, checked functionallity, works on my side
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Marked as no breaking changes, since its "just" a broken Link that didn't worked
TODO:
Add actual c#-markup How To to that article since its actually only including xaml markup support for that
Internal Issue (If applicable):
Generated no issue before because it was a quick fix of a Link