-
Notifications
You must be signed in to change notification settings - Fork 747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(implicit packages):Adding MAUI and C# markup packages when enabled #18703
Conversation
@LuisAlfredo92 please make sure to reword the commits to adhere to Conventional Commits spec https://www.conventionalcommits.org/en/v1.0.0/ |
I did the change, is it correct now? Or do I have to create the fork again? |
src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.targets
Outdated
Show resolved
Hide resolved
Thanks for your contribution! |
Adding MAUI and C# Markup packages when they are selected in templates. Also, found a probable typo that could cause the original problem refs: #18700
7ef0fd7
to
0397050
Compare
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18703/index.html |
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18703/index.html |
Congrats on your first pull-request! We ❤ the people who are involved in this project, and we’d love to pay it forward by sending you some swag. If you have any feedback (or ideas how to improve Uno as a open-source project) please open a feedback issue. |
Also found a probable typo
GitHub Issue (If applicable): closes #18700
PR Type
What kind of change does this PR introduce?
What is the current behavior?
You have to add the NuGet package manually
What is the new behavior?
It adds it automatically to the main project
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.Other information
Number of tests passed and failed didn't change
Internal Issue (If applicable): #18700