Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(implicit packages):Adding MAUI and C# markup packages when enabled #18703

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

LuisAlfredo92
Copy link
Contributor

@LuisAlfredo92 LuisAlfredo92 commented Nov 5, 2024

Also found a probable typo

GitHub Issue (If applicable): closes #18700

PR Type

What kind of change does this PR introduce?

  • Project automation

What is the current behavior?

You have to add the NuGet package manually

What is the new behavior?

It adds it automatically to the main project

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Number of tests passed and failed didn't change
imagen

Internal Issue (If applicable): #18700

@MartinZikmund
Copy link
Member

@LuisAlfredo92 please make sure to reword the commits to adhere to Conventional Commits spec https://www.conventionalcommits.org/en/v1.0.0/

@LuisAlfredo92 LuisAlfredo92 changed the title Adding MAUI packages when MAUI embedding is enabled fix(implicit packages):Adding MAUI and C# markup packages when enabled Nov 7, 2024
@LuisAlfredo92
Copy link
Contributor Author

I did the change, is it correct now? Or do I have to create the fork again?

@jeromelaban
Copy link
Member

Thanks for your contribution!

Adding MAUI and C# Markup packages when they are selected in templates. Also, found a probable typo that could cause the original problem

refs: #18700
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18703/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18703/index.html

@jeromelaban jeromelaban merged commit 7135b26 into unoplatform:master Nov 19, 2024
114 of 115 checks passed
Copy link

welcome bot commented Nov 19, 2024

Congrats on your first pull-request! We ❤ the people who are involved in this project, and we’d love to pay it forward by sending you some swag. If you have any feedback (or ideas how to improve Uno as a open-source project) please open a feedback issue.
giphy
Merci beaucoup 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding Uno.Extensions.Maui.WinUI.Markup automatically if they use MAUI and C# markup
4 participants