fix(xLoad): fix unload-reload scenarios when using x:Bind with x:Load #19174
+104
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramezgerges
commented
Jan 9, 2025
Comment on lines
+203
to
+208
| if ((this as IDependencyObjectStoreProvider).Store.GetPropertyDetails(DataContextProperty) | ||
| .CurrentHighestValuePrecedence > DependencyPropertyValuePrecedences.Local) | ||
| { | ||
| this.SetValue(DataContextProperty, DataContext, DependencyPropertyValuePrecedences.Local); | ||
| } | ||
|
|
There was a problem hiding this comment.
For the record, I really don't like this, but I don't see a better way of fixing this with the way x:Bind is currently implemented.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #18509
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):