Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix regression in code gen #19182

Merged
merged 1 commit into from
Jan 10, 2025
Merged

fix: Fix regression in code gen #19182

merged 1 commit into from
Jan 10, 2025
+363 −2

Conversation

dr1rrb
Copy link
Member

@dr1rrb dr1rrb commented Jan 9, 2025

Bugfix

Fix regression in code gen

What is the current behavior?

Code gen might generate invalid code in some specific case describe in the added tests.

What is the new behavior?

Gen'ed code is valid.

PR Checklist

@github-actions github-actions bot added the area/code-generation Categorizes an issue or PR as relevant to code generation label Jan 9, 2025
@dr1rrb dr1rrb enabled auto-merge January 9, 2025 18:03
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19182/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19182/index.html

@jeromelaban jeromelaban disabled auto-merge January 10, 2025 04:49
@jeromelaban jeromelaban merged commit c992ed0 into master Jan 10, 2025
112 of 114 checks passed
@jeromelaban jeromelaban deleted the dev/dr/hrReg branch January 10, 2025 04:50
@jeromelaban
Copy link
Member

@Mergifyio backport release/stable/5.6

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 10, 2025 •
edited
Loading

backport release/stable/5.6

✅ Backports have been created

@mergify mergify bot mentioned this pull request Jan 10, 2025
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromelaban jeromelaban jeromelaban approved these changes

@ajpinedam ajpinedam ajpinedam approved these changes

Assignees
No one assigned
Labels
area/code-generation Categorizes an issue or PR as relevant to code generation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dr1rrb @unodevops @jeromelaban @ajpinedam