chore(devSrv): Improve reliability of connection by catching generic errors #19319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…errors (like a serilization issue)
nickrandolph
approved these changes
Jan 24, 2025
jeromelaban
approved these changes
Jan 24, 2025
|
@Mergifyio backport release/stable/5.6 |
✅ Backports have been created
|
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19319/index.html |
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19319/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19319/index.html |
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19319/index.html |
|
The build 153114 found UI Test snapshots differences: Details
|
jeromelaban
added a commit
that referenced
this pull request
Jan 25, 2025
…5.6/pr-19319 chore(devSrv): Improve reliability of connection by catching generic errors (backport #19319)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix
Improve reliability of connection by catching generic errors (like a serilization issue)
What is the current behavior?
Connection is dropped if there is a serilization (for instance due a the linker)
What is the new behavior?
Log error and wait for next frame.
PR Checklist
Screenshots Compare Test Runresults.