New login and signup #1117
New login and signup #1117
Conversation
New signup
coderatomy
added
the
create-test-vm
|
@coderatomy is creating a test VM for this PR 🚀🚀🚀 |
|
pre-commit checks failed ❌❌❌ |
|
Test VM is ready ✅✅✅ |
NdibeRaymond
removed
the
create-test-vm
|
@NdibeRaymond is deleting test VM ... |
|
Test VM deleted ✅✅✅ |
|
@coderatomy when you have the time please fix the issues being reported by pre-commit here |
| @@ -76,6 +76,8 @@ function NavBar(props) { | |||
| const [searchType, setSearchType] = useState(getQueryParams(window.location.href).get('type') || SearchType.PROJECTS); | |||
| const formRef = useRef(); | |||
| const token = useSelector(state => state.auth.token); | |||
| const pathname = props.location?.pathname | |||
| const hideSearchAndActions = pathname === '/signup' || pathname === '/login'; | |||
There was a problem hiding this comment.
@coderatomy is this part of the requirements? I think a user should be allowed access to the search box even in the signup page (since are user can search for things while not logged in)
| @@ -214,32 +214,67 @@ export const setLabelWidthOfStaticFields = (refs, document, props) => { | |||
| * @todo - describe object's function | |||
| */ | |||
| export const validationSchema = Yup.object().shape({ | |||
| role: Yup.string().required('Please choose a role'), | |||
| password1: Yup.string().min(8, 'min').required('required'), | ||
| password2: Yup.string() | ||
| .oneOf([Yup.ref('password1'), null], 'noMatch') | ||
| email: Yup.string().email('invalid').required('Add your email'), |
| // return vars.email_field_touched && !value && !this.parent.phone ? false : true; | ||
| // }), | ||
| phone: Yup.string(), | ||
| // .test('phone_is_invalid', 'invalid', function () { |
There was a problem hiding this comment.
why are you commenting these out?
| // .test('phone_is_empty', 'phoneOrEmail', function () { | ||
| // return vars.phone_field_touched && !vars.iti.getNumber() && !this.parent.email ? false : true; | ||
| // }), | ||
| dateOfBirth: Yup.date().required('required'), |
There was a problem hiding this comment.
why was this changed?
| </CardActionArea> | ||
| </Card> | ||
| </Container> | ||
| <Box width={'100%'}> |
There was a problem hiding this comment.
fix this. This should either be in the styles or not at all
There was a problem hiding this comment.
why did you remove classes.root?
| direction="column" | ||
| maxWidth={'600px'} | ||
| margin={'auto'} | ||
| rowSpacing={{ xs: 2, sm: 3, md: 5 }} |
| <form onSubmit={handleSubmit}> | ||
| <Grid item> | ||
| <Typography align="center" className={mainClasses.header2}> | ||
| Welcome to ZubHub ! |
There was a problem hiding this comment.
you removed all the translations
| Welcome to ZubHub ! | ||
| </Typography> | ||
| <Typography align="center" className={mainClasses.text2}> | ||
| Log Into your ZubHub account to share ideas |
There was a problem hiding this comment.
please return the translation
| handleBlur, | ||
| handleSubmit, | ||
| touched, | ||
| } = useFormik({ |
There was a problem hiding this comment.
unless the way we were using formik before is no longer working, please use it the same way
|
there are more changes to make than I can possibly comment on, but let's start with these first |
|
pre-commit checks failed ❌❌❌ |
Summary
New auth