-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more tests for instructor permissions to fetch ddahs #599
Merged
siefkenj
merged 17 commits into
uoft-tapp:master
from
alex-kozin:feat/test-fetch-instructor-ddahs
Jun 20, 2021
+336
−88
Merged
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
05e7b6f
More tests.
alex-kozin e6f3e64
Failing ddah creation...
alex-kozin cfdd994
Work from before.
alex-kozin 60df9a7
Seed ddahs for two instructors, fix some tests.
alex-kozin 1e92a33
Use default jest method instead of custom ToContainObject.
alex-kozin d96f085
One more test.
alex-kozin cc290d7
Add a failing test.
alex-kozin 35aa1e8
Added another test for updating the DDAH.
alex-kozin 407a95c
Lint
alex-kozin 4697c51
Remove .only
alex-kozin e88b52a
Add spacing.
alex-kozin ed81b31
Address feedback.
alex-kozin c79b3af
Rename foreignAssignment.
alex-kozin 7bcb145
Rename temp ids.
alex-kozin debb745
Delete unnecessary calls, grab data from seeder.
alex-kozin 0f7b174
Trivial change.
alex-kozin c88d272
Lint setup please.
alex-kozin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alex-kozin Fix this - delete all properties with an underscore