-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update uptest to v1.1.2 #46
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaessert
force-pushed
the
update_uptest
branch
from
October 7, 2024 10:23
d7915b7
to
a978ba1
Compare
ytsarev
reviewed
Oct 7, 2024
kaessert
force-pushed
the
update_uptest
branch
3 times, most recently
from
October 7, 2024 11:44
3d2a38e
to
94d235d
Compare
ytsarev
reviewed
Oct 7, 2024
kaessert
force-pushed
the
update_uptest
branch
2 times, most recently
from
October 7, 2024 12:29
4bcd020
to
3997bdf
Compare
kaessert
force-pushed
the
update_uptest
branch
from
October 7, 2024 12:53
3997bdf
to
9d9fe68
Compare
ytsarev
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made e2e test of uptest
- Standard run
make e2e
...
2024/10/07 16:55:10 /bin/sh -c ${KUBECTL} wait managed --all --for=delete --timeout -1s
2024/10/07 16:55:10 | 16:55:10 | delete | Assert Deletion | SCRIPT | DONE |
2024/10/07 16:55:10 | 16:55:10 | delete | Assert Deletion | TRY | DONE |
2024/10/07 16:55:10 --- PASS: chainsaw (0.00s)
2024/10/07 16:55:10 --- PASS: chainsaw/delete (30.72s)
2024/10/07 16:55:10 PASS
2024/10/07 16:55:10 Tests Summary...
2024/10/07 16:55:10 - Passed tests 1
2024/10/07 16:55:10 - Failed tests 0
2024/10/07 16:55:10 - Skipped tests 0
2024/10/07 16:55:10 Done.
16:55:10 [ OK ] running automated tests
- New way to skip deletion
make e2e UPTEST_EXTRA_ARGS=--skip-delete
...
2024/10/07 17:13:45 | 17:13:45 | apply | Assert Status Conditions | TRY | DONE |
2024/10/07 17:13:45 --- PASS: chainsaw (0.00s)
2024/10/07 17:13:45 --- PASS: chainsaw/apply (22.97s)
2024/10/07 17:13:45 PASS
2024/10/07 17:13:45 Tests Summary...
2024/10/07 17:13:45 - Passed tests 1
2024/10/07 17:13:45 - Failed tests 0
2024/10/07 17:13:45 - Skipped tests 0
2024/10/07 17:13:45 Done.
2024/10/07 17:13:45 Skipping test 01-update.yaml
2024/10/07 17:13:45 Skipping test 02-import.yaml
2024/10/07 17:13:45 Skipping test 03-delete.yaml
17:13:45 [ OK ] running automated tests
- Render
make render
---
apiVersion: platform.upbound.io/v1alpha1
kind: App
metadata:
annotations:
render.crossplane.io/composition-path: apis/composition.yaml
render.crossplane.io/function-path: examples/functions.yaml
name: configuration-app
namespace: default
spec:
compositeDeletePolicy: Foreground
parameters:
passwordSecretRef:
name: configuration-app-mariadb
namespace: default
providerConfigName: uptest
writeConnectionSecretToRef:
name: configuration-app
status:
conditions:
- lastTransitionTime: "2024-01-01T00:00:00Z"
message: 'Unready resources: helmRelease'
reason: Creating
status: "False"
type: Ready
---
apiVersion: helm.crossplane.io/v1beta1
kind: Release
metadata:
annotations:
crossplane.io/composition-resource-name: helmRelease
render.crossplane.io/composition-path: apis/composition.yaml
render.crossplane.io/function-path: examples/functions.yaml
generateName: configuration-app-
labels:
crossplane.io/composite: configuration-app
ownerReferences:
- apiVersion: platform.upbound.io/v1alpha1
blockOwnerDeletion: true
controller: true
kind: App
name: configuration-app
uid: ""
spec:
forProvider:
chart:
name: ghost
repository: https://charts.bitnami.com/bitnami
version: 19.3.10
namespace: ghost
set:
- name: externalDatabase.host
valueFrom:
secretKeyRef:
key: host
name: configuration-app-mariadb
namespace: default
- name: externalDatabase.user
valueFrom:
secretKeyRef:
key: username
name: configuration-app-mariadb
namespace: default
- name: externalDatabase.password
valueFrom:
secretKeyRef:
key: password
name: configuration-app-mariadb
namespace: default
values:
externalDatabase:
database: upbound
port: 3306
ghostBlogTitle: Upbound Rocks!
ghostHost: upboundrocks.cloud
mysql:
enabled: false
persistence:
enabled: false
providerConfigRef:
name: uptest
rollbackLimit: 3
Everything works as expected.
@kaessert thanks a lot for all enhancements!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Updated uptest to latest version v1.1.2
Fixes #
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR, as appropriate.How has this code been tested
Automated e2e tests