Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expose wait parameter to the outside #47

Merged
merged 1 commit into from
Oct 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions apis/composition.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ spec:
enabled: false
persistence:
enabled: false
wait: true
rollbackLimit: 3
patches:
- type: FromCompositeFieldPath
Expand All @@ -69,6 +70,9 @@ spec:
- type: FromCompositeFieldPath
fromFieldPath: spec.parameters.helm.chart.version
toFieldPath: spec.forProvider.chart.version
- type: FromCompositeFieldPath
fromFieldPath: spec.parameters.helm.wait
toFieldPath: spec.forProvider.wait
- type: FromCompositeFieldPath
fromFieldPath: spec.parameters.passwordSecretRef.namespace
toFieldPath: spec.forProvider.set[0].valueFrom.secretKeyRef.namespace
Expand Down
5 changes: 5 additions & 0 deletions apis/definition.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,11 @@ spec:
version:
type: string
description: chart version
wait:
type: boolean
decription: |
Whether to wait or not for resources to be healthy or deletd when installing
or deleting the chart
passwordSecretRef:
type: object
description: "A reference to the Secret object containing database credentials"
Expand Down
2 changes: 2 additions & 0 deletions examples/app-claim.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ metadata:
spec:
compositeDeletePolicy: Foreground
parameters:
helm:
wait: false
providerConfigName: uptest
passwordSecretRef:
namespace: default
Expand Down