Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve KCL devex #68

Merged
merged 4 commits into from
Aug 1, 2024
Merged

Improve KCL devex #68

merged 4 commits into from
Aug 1, 2024

Conversation

ytsarev
Copy link
Member

@ytsarev ytsarev commented Jul 16, 2024

Description of your changes

Enables to develop KCL code for function-kcl without embedding it into YAML

  • Move out KCL code to a separate file
  • Use standard YAML for Composition template
  • Generate final composition with generate-composition.k
  • Adapt make build and make render-kcl make targets

I have:

  • Read and followed Upbound's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

make build
make render-kcl

Enables to develop KCL code for function-kcl without embedding it into YAML

* Move out KCL code to a separate file
* Use standard YAML for Composition template
* Generate final composition with generate-composition.k
* Adapt `make build` and `make render-kcl` make targets

Signed-off-by: Yury Tsarev <[email protected]>

# generated by kcl
apis/composition-kcl-generated.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apis/template.yaml

@@ -19,7 +19,7 @@ UPTEST_VERSION = v0.11.1
# ====================================================================================
# Setup XPKG
XPKG_DIR = $(shell pwd)
XPKG_IGNORE = .github/workflows/*.yaml,.github/workflows/*.yml,examples/*.yaml,.work/uptest-datasource.yaml
XPKG_IGNORE = .github/workflows/*.yaml,.github/workflows/*.yml,examples/*.yaml,.work/uptest-datasource.yaml,apis/composition-kcl.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apis/template.yaml

@haarchri haarchri merged commit 4e79799 into upbound:main Aug 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants