This repository has been archived by the owner on Jan 2, 2025. It is now read-only.
Rename R function from AppendSlopeFeatures to append_slope_features #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose we rename the R function
AppendSlopeFeatures
toappend_slope_features
to match the interface of the Python package.Lower-snake-case is also a commonly used style in R, e.g., see Tidyverse style guide, so I think most R users may find this change to even be an improvement.
This PR makes progress towards #13