Fix areNotificationsAllowed retrieval on Android #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Fixes the push status method by using resolveDeferred instead of resolveResult so that the coroutine can complete and the serializable status can be sent back.
Also removes a duplicate implementation for feature flags trackInteraction method.
Why are these changes necessary?
The push status method isn't functioning as it should. The original implementation was returning a coroutine directly through the platform channel which isn't serializable.
How did you verify these changes?
Isolated the issue and reproduced the exception, then making the fix and testing the retrieval flow on launch:
https://gist.github.com/crow/6bdebcb6f04155ca2d3978c9e891db31