Android Add hybrid app hooks #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlepinski
commented
Oct 23, 2024
| * @param configBuilder The config builder | ||
| * @return The config builder. | ||
| */ | ||
| public fun extendConfig( |
There was a problem hiding this comment.
Instead of making this a breaking change we could add a new interface that the pluginExtender could optionally implement. That makes it a little harder to use though
crow
approved these changes
Oct 23, 2024
jyaganeh
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to modify config programmatically and set forward listeners.
This will have to be another major rev to the proxy and frameworks since the airship extender optional method does not bind to Java. There are some flags to make defaults work but it requires special compiler flags, not sure if we want to go down that route.