Skip to content

Commit

Permalink
Release 18.14.2 (#3337)
Browse files Browse the repository at this point in the history
* Fix banner spacing without heading

* Release 18.14.2
  • Loading branch information
rlepinski authored Jan 9, 2025
1 parent f32766e commit 89003c3
Show file tree
Hide file tree
Showing 9 changed files with 20 additions and 13 deletions.
2 changes: 1 addition & 1 deletion Airship.podspec
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
AIRSHIP_VERSION="18.14.1"
AIRSHIP_VERSION="18.14.2"

Pod::Spec.new do |s|
s.version = AIRSHIP_VERSION
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ struct InAppMessageBannerView: View {
.fixedSize(horizontal: false, vertical: true)
.accessibilityAddTraits(.isHeader)
.accessibilityAddTraits(.isStaticText)
.applyAlignment(placement: heading.alignment ?? .left)
}
}

Expand All @@ -48,6 +49,7 @@ struct InAppMessageBannerView: View {
TextView(textInfo: body, textTheme: self.theme.body)
.fixedSize(horizontal: false, vertical: true)
.accessibilityAddTraits(.isStaticText)
.applyAlignment(placement: body.alignment ?? .left)
}
}

Expand Down Expand Up @@ -110,15 +112,15 @@ struct InAppMessageBannerView: View {
HStack(alignment: .top, spacing: 16) {
mediaView
VStack(alignment: .center, spacing: 16) {
headerView.applyAlignment(placement: displayContent.heading?.alignment ?? .left)
bodyView.applyAlignment(placement: displayContent.body?.alignment ?? .left)
headerView
bodyView
}
}
case .mediaRight:
HStack(alignment: .top, spacing: 16) {
VStack(alignment: .center, spacing: 16) {
headerView.applyAlignment(placement: displayContent.heading?.alignment ?? .left)
bodyView.applyAlignment(placement: displayContent.body?.alignment ?? .left)
headerView
bodyView
}
mediaView
}
Expand Down
2 changes: 1 addition & 1 deletion Airship/AirshipConfig.xcconfig
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
//* Copyright Airship and Contributors */

CURRENT_PROJECT_VERSION = 18.14.1
CURRENT_PROJECT_VERSION = 18.14.2

// Uncomment to include the preview build warning
// OTHER_CFLAGS = $(inherited) -DUA_PREVIEW=1
2 changes: 1 addition & 1 deletion Airship/AirshipCore/Source/AirshipVersion.swift
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import Foundation

public struct AirshipVersion {
public static let version = "18.14.1"
public static let version = "18.14.2"
public static func get() -> String {
return version
}
Expand Down
2 changes: 1 addition & 1 deletion AirshipContentExtension.podspec
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
AIRSHIP_VERSION="18.14.1"
AIRSHIP_VERSION="18.14.2"

Pod::Spec.new do |s|
s.version = AIRSHIP_VERSION
Expand Down
2 changes: 1 addition & 1 deletion AirshipDebug.podspec
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
AIRSHIP_VERSION="18.14.1"
AIRSHIP_VERSION="18.14.2"

Pod::Spec.new do |s|
s.version = AIRSHIP_VERSION
Expand Down
2 changes: 1 addition & 1 deletion AirshipServiceExtension.podspec
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
AIRSHIP_VERSION="18.14.1"
AIRSHIP_VERSION="18.14.2"

Pod::Spec.new do |s|
s.version = AIRSHIP_VERSION
Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@

# iOS Changelog

## Version 18.14.2 January 9, 2025
Patch release to fix extra spacing in a Banner In-App Automations if its missing the heading or body.

### Changes
- Fix Banner In-App Automation extra spacing.

## Version 18.14.1 December 20, 2024
Patch release to fix Banner In-App Automations if the image is taller than the text.

Expand Down
5 changes: 2 additions & 3 deletions Thomas/Thomas/Resources/Messages/Banner/small-banner.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,13 @@
"background_color" : "#ffffff",
"border_radius" : 5,
"dismiss_button_color" : "#000000",
"heading" : {
"body" : {
"alignment" : "center",
"color" : "#63aff2",
"font_family" : [
"sans-serif"
],
"size" : 22,
"text" : "Boom"
"text" : "Text body, text body, text body, text body, text body"
},
"template" : "media_left",
"placement" : "bottom",
Expand Down

0 comments on commit 89003c3

Please sign in to comment.