Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disk: fix broken chop error message #642

Merged
merged 1 commit into from
May 1, 2024
Merged

disk: fix broken chop error message #642

merged 1 commit into from
May 1, 2024

Conversation

pkova
Copy link
Collaborator

@pkova pkova commented May 1, 2024

#635 broke the develop branch and therefore broke CI on urbit/urbit. It's a real C moment that CI failed to catch this one.

@pkova pkova requested a review from a team as a code owner May 1, 2024 16:51
@pkova pkova merged commit 639d032 into develop May 1, 2024
4 checks passed
@pkova pkova deleted the pkova/chop-chop branch May 1, 2024 16:54
Copy link
Member

@joemfb joemfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous version is valid in c. String literals separated by whitespace are automatically concatenated.

@pkova
Copy link
Collaborator Author

pkova commented May 1, 2024

Yup, not this. Reverting.

pkova added a commit that referenced this pull request May 2, 2024
Reverts #642

There's something very mysterious going on, `urbit/urbit` CI segfaults
but `urbit/vere` does not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants