Merge develop to next/kelvin/410 #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Debugging vere on macOS is quite something because as soon as we get a single SIGSEGV lldb enters an infinite loop. The cause of that is a lldb bug and the root cause of that is a macos kernel bug. Here we implement the same workaround that Go does to make the debugger work. https://bugs.llvm.org/show_bug.cgi?id=22868#c1
Same as urbit/urbit#3261 but for vere. From what I can tell this NAT-PMP stuff is fairly well supported by routers, works on my machine at least.
#635 broke the develop branch and therefore broke CI on `urbit/urbit`. It's a real C moment that CI failed to catch this one.
Reverts #593 This is very likely what is breaking `urbit/urbit` CI.
Reverts #642 There's something very mysterious going on, `urbit/urbit` CI segfaults but `urbit/vere` does not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.