ames: factor out stun implementation and basic de/serialization functions #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkova
approved these changes
Jul 2, 2024
|
For posterity @ripperi noticed that having a fakezod and a fake planet up on the same machine on any commit after e135995 would cause both ships to be at 100% cpu on the king. They were sending stun requests to eachother at full blast for some reason. It is unclear why this PR fixes the issue, but it does. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR factors out a couple small modules from ames, in anticipation of merging in the directed messaging driver. Built on top of (and targeting) #639.