WIP: Make version stuff in dashboard client public

urfeex · Jan 10, 2025 · ad2004b · ad2004b
1 parent 89bcf27
commit ad2004b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/include/ur_client_library/ur/dashboard_client.h b/include/ur_client_library/ur/dashboard_client.h
@@ -434,7 +434,6 @@ class DashboardClient : public comm::TCPSocket
    */
   bool commandSaveLog();
 
-private:
   /*!
    * \brief Makes sure that the dashboard_server's version is above the required version
    *
@@ -446,9 +445,7 @@ class DashboardClient : public comm::TCPSocket
    */
   void assertVersion(const std::string& e_series_min_ver, const std::string& cb3_min_ver,
                      const std::string& required_call);
-  bool send(const std::string& text);
-  std::string read();
-  void rtrim(std::string& str, const std::string& chars = "\t\n\v\f\r ");
+  VersionInformation polyscope_version_;
 
   /*!
    * \brief Gets the configured receive timeout. If receive timeout is unconfigured "normal" socket timeout of 1 second
@@ -458,7 +455,11 @@ class DashboardClient : public comm::TCPSocket
    */
   timeval getConfiguredReceiveTimeout() const;
 
-  VersionInformation polyscope_version_;
+private:
+  bool send(const std::string& text);
+  std::string read();
+  void rtrim(std::string& str, const std::string& chars = "\t\n\v\f\r ");
+
   std::string host_;
   int port_;
   std::mutex write_mutex_;

diff --git a/tests/test_dashboard_client.cpp b/tests/test_dashboard_client.cpp
@@ -34,7 +34,6 @@
 #include <thread>
 #include "ur_client_library/comm/tcp_socket.h"
 #include "ur_client_library/ur/version_information.h"
-#define private public
 #include <ur_client_library/ur/dashboard_client.h>
 
 using namespace urcl;