Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add aggregated info of selected users to report view #906

Merged
merged 25 commits into from
Nov 15, 2024

Conversation

bseber
Copy link
Contributor

@bseber bseber commented Oct 25, 2024

closes #878

TODOs:

  • Ausblenden wenn die Ansicht nur für mich ist
  • Umsetzung der Wochen-Ansicht
  • angezeigte Zahlen auf Korrektheit verifizieren
    • aktuell wird mehr SOLL als GEPLANT angezeigt
    • SOLL (should): geplante Arbeitszeit abzüglich Abwesenheiten
    • GEPLANT (planned): geplante Arbeitszeit. z. B. in einer Woche 40h bei 5 Tagen a 8h.
  • [ ] wenn im Graphen ein Tag ausgewählt wird, wie soll sich die Tabelle verhalten? (Berichte: Zusammengefasste Informationen zu Personen auf ausgewählten Tag aktualisieren #911)
    • Information nur für den Tag anzeigen?
    • Zusätzlich die Information für diesen Tag anzeigen?

Here are some things you should have thought about:

Multi-Tenancy

  • Extended new entities with AbstractTenantAwareEntity?
  • New entity added to TenantAwareDatabaseConfiguration?
  • Tested with dev-multitenant profile?

@bseber bseber changed the title add selected user aggregated info to report view add aggregated info of selected users to report view Oct 25, 2024
@bseber bseber added this to the 2.11.0 milestone Oct 25, 2024
@github-actions github-actions bot added the status: planned This issue is planned in a milestone and won't be touched by stale bot. label Oct 25, 2024
@bseber bseber force-pushed the 878-reports-show-person-aggregated-detail branch from 4c754d9 to c00947c Compare October 25, 2024 15:05
@derTobsch derTobsch modified the milestones: 2.11.0, 2.12.0 Oct 29, 2024
@github-actions github-actions bot added status: new Initial state for every issue / pullrequest status: planned This issue is planned in a milestone and won't be touched by stale bot. and removed status: planned This issue is planned in a milestone and won't be touched by stale bot. status: new Initial state for every issue / pullrequest labels Oct 29, 2024
@derTobsch derTobsch modified the milestones: 2.12.0, 2.13.0 Oct 31, 2024
@github-actions github-actions bot added status: new Initial state for every issue / pullrequest status: planned This issue is planned in a milestone and won't be touched by stale bot. and removed status: planned This issue is planned in a milestone and won't be touched by stale bot. status: new Initial state for every issue / pullrequest labels Oct 31, 2024
@honnel
Copy link
Contributor

honnel commented Nov 6, 2024

Small ui glitch
grafik

@bseber bseber force-pushed the 878-reports-show-person-aggregated-detail branch from d01638d to 7307cf1 Compare November 15, 2024 09:49
@honnel honnel force-pushed the 878-reports-show-person-aggregated-detail branch from a755031 to 2ec3f83 Compare November 15, 2024 11:19
@bseber bseber force-pushed the 878-reports-show-person-aggregated-detail branch 2 times, most recently from 98c0d92 to d0a8156 Compare November 15, 2024 13:28
@bseber bseber marked this pull request as ready for review November 15, 2024 13:29
@derTobsch derTobsch force-pushed the 878-reports-show-person-aggregated-detail branch from dde1c50 to 8458bd3 Compare November 15, 2024 14:03
tooltip is below the following row th (next username)
don't know how to fix this currently, th has position: sticky which then is on top of the previous tooltip element
Copy link

sonarcloud bot commented Nov 15, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
78.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@derTobsch derTobsch merged commit 8f9a08c into main Nov 15, 2024
2 of 3 checks passed
@derTobsch derTobsch deleted the 878-reports-show-person-aggregated-detail branch November 15, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: planned This issue is planned in a milestone and won't be touched by stale bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Berichte: Noch zu leistende Arbeitszeit / Mehr geleistet Arbeitszeit zu ausgewählten Personen anzeigen
3 participants