Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release report maintenance and Microbenchmark UI change #76

Merged
merged 11 commits into from
Jan 12, 2024

Conversation

boshek
Copy link
Contributor

@boshek boshek commented Jan 11, 2024

This PR does a bit of maintenance on the release report including:

  • bump the version of conbenchcoms
  • properly facet macrobenchmarks by cleaning up label

This report is tested locally by comparing this baseline apache/arrow@2dcee3f to this contender apache/arrow@f60c281

This PR also re-enables changes previously reverted in #73.

FYI @assignUser and @raulcd

@assignUser
Copy link
Contributor

Nice! Could you add those commits into the workflow so we don't just get the empty page with a warning as the artifact?

@assignUser
Copy link
Contributor

Looking at the rendered report a verbatime html thing seems to have snuck in:
image
Also visible when something is selected. Btw why re-revert of #73? (probably a discussion happened offline?)
image

@boshek
Copy link
Contributor Author

boshek commented Jan 12, 2024

Looking at the rendered report a verbatime html thing seems to have snuck in: image Also visible when something is selected. Btw why re-revert of #73? (probably a discussion happened offline?) image

Ah good catch thanks. Should be good to go now.

Copy link
Contributor

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@assignUser assignUser merged commit cc45293 into ursacomputing:main Jan 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants