Skip to content

Commit

Permalink
update
Browse files Browse the repository at this point in the history
  • Loading branch information
ivukotic committed Jan 26, 2024
1 parent a12d66e commit 0884f5d
Show file tree
Hide file tree
Showing 6 changed files with 1,094 additions and 1,042 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/base_builder.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Build AnalysisBase base image
on:
push:
branches:
- main
- "*"
tags:
- "v*.*.*"
pull_request:
Expand Down
8 changes: 4 additions & 4 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
lock:
docker pull gitlab-registry.cern.ch/atlas/athena/analysisbase:24.2.26
docker pull gitlab-registry.cern.ch/atlas/athena/analysisbase:24.2.37
docker build \
--file docker/Dockerfile.lockfile-builder \
--build-arg BASE_IMAGE=gitlab-registry.cern.ch/atlas/athena/analysisbase:24.2.26 \
--build-arg BASE_IMAGE=gitlab-registry.cern.ch/atlas/athena/analysisbase:24.2.37 \
--tag tmp/analysisbase:rel24-lockfile-builder \
docker
docker run \
Expand All @@ -19,10 +19,10 @@ lock:
rm -r venv'

build:
docker pull gitlab-registry.cern.ch/atlas/athena/analysisbase:24.2.26
docker pull gitlab-registry.cern.ch/atlas/athena/analysisbase:24.2.37
docker build \
--file docker/Dockerfile \
--build-arg BASE_IMAGE=gitlab-registry.cern.ch/atlas/athena/analysisbase:24.2.26 \
--build-arg BASE_IMAGE=gitlab-registry.cern.ch/atlas/athena/analysisbase:24.2.37 \
--tag sslhep/analysis-dask-base:debug \
.

Expand Down
25 changes: 15 additions & 10 deletions docker/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG BASE_IMAGE=gitlab-registry.cern.ch/atlas/athena/analysisbase:24.2.26
ARG BASE_IMAGE=gitlab-registry.cern.ch/atlas/athena/analysisbase:24.2.37
FROM ${BASE_IMAGE} as base

SHELL [ "/bin/bash", "-c" ]
Expand All @@ -7,8 +7,8 @@ USER root

# needed for dasklab extension.
RUN yum install -y \
nodejs \
graphviz && \
nodejs \
graphviz && \
yum clean all

# Add Tini
Expand Down Expand Up @@ -43,24 +43,29 @@ RUN chmod +x /tini && \
chmod +x /cmd.sh && \
chmod +x /release_setup.sh

RUN git clone https://github.com/scikit-hep/uproot5.git
WORKDIR /analysis/uproot5
RUN pip install -e .
WORKDIR /analysis

# Need to use an additonal directory beyond /usr/AnalysisBase to install
# given how ATLAS CMake works.
# c.f. https://gitlab.cern.ch/gstark/pycolumnarprototype/-/issues/2
RUN . /release_setup.sh && \
cd /tmp && \
git clone \
--recurse-submodules \
--branch py_el_tool_test \
--recurse-submodules \
--branch py_el_tool_test \
https://gitlab.cern.ch/gstark/pycolumnarprototype.git && \
cd pycolumnarprototype && \
cmake \
-S src \
-B build && \
-S src \
-B build && \
cmake build -LH && \
cmake \
--build build \
--clean-first \
--parallel "$(nproc --ignore=1)" && \
--build build \
--clean-first \
--parallel "$(nproc --ignore=1)" && \
DESTDIR=/usr/tools cmake --install build && \
cd /tmp && \
rm -rf pycolumnarprototype && \
Expand Down
2 changes: 1 addition & 1 deletion docker/Dockerfile.lockfile-builder
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG BASE_IMAGE=gitlab-registry.cern.ch/atlas/athena/analysisbase:24.2.26
ARG BASE_IMAGE=gitlab-registry.cern.ch/atlas/athena/analysisbase:24.2.37
FROM ${BASE_IMAGE} as base

SHELL [ "/bin/bash", "-c" ]
Expand Down
Loading

0 comments on commit 0884f5d

Please sign in to comment.