Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial pass at docs #160

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

initial pass at docs #160

wants to merge 12 commits into from

Conversation

jGaboardi
Copy link
Collaborator

  • This is an initial pass at docs; nowhere near complete.
  • @martinfleis & @anastassiavybornova let me know how this is looking so far
  • Also, what other sections to include / exclude etc.
  • Need to think about what / how many notebooks and what data to include for that
    • perhaps use Apalachicola (or some other small place)?
    • either way, we might want to move apalachicola_original.parquet from neatnet/tests/data/ into a neatnet /data/ directory

xref:

@jGaboardi jGaboardi added the documentation Improvements or additions to documentation label Dec 26, 2024
@jGaboardi jGaboardi self-assigned this Dec 26, 2024
@martinfleis
Copy link
Contributor

We need the dependencies defined somewhere, possibly in pixi env. Had to add like 6 packages to make it run :).

Let's talk about the structure in person.

@jGaboardi
Copy link
Collaborator Author

We need the dependencies defined somewhere, possibly in pixi env. Had to add like 6 packages to make it run :).

I think I was probably doing this in a conda environment when I did initially. Still haven't fully adopted the pixi paradigm, very cumbersome – but do not lose faith in me.

Let's talk about the structure in person.

So how do we want to proceed?

@martinfleis
Copy link
Contributor

I have pushed an update to ensure all deps come with pixi tests env and in 0759d77 a proposal on what I think could be exposed as a public API.

@martinfleis
Copy link
Contributor

Furthermore, I would move close_gaps, extend_lines and FaceArtifacts from momepy here and make them a part of public API as well.

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.8%. Comparing base (cca5abf) to head (b732b5c).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #160   +/-   ##
=====================================
  Coverage   98.8%   98.8%           
=====================================
  Files          6       6           
  Lines        998     998           
=====================================
  Hits         986     986           
  Misses        12      12           
Files with missing lines Coverage Δ
neatnet/__init__.py 100.0% <100.0%> (ø)
neatnet/artifacts.py 97.9% <ø> (ø)
neatnet/simplify.py 98.2% <ø> (ø)

@martinfleis
Copy link
Contributor

perhaps use Apalachicola (or some other small place)?

I'd rather not as the Apalachicola case only works if you include sidewalks as we do in our tests. But normally, you should start with data without. Some other small-ish place?

@jGaboardi
Copy link
Collaborator Author

perhaps use Apalachicola (or some other small place)?

I'd rather not as the Apalachicola case only works if you include sidewalks as we do in our tests. But normally, you should start with data without. Some other small-ish place?

Since we depend on momepy why not Bubenec? Or is that too small?

@martinfleis
Copy link
Contributor

There's nothing to simplify.

@jGaboardi
Copy link
Collaborator Author

  • pixi updates – Thanks!
  • public API – I'm OK with that
  • transfered momepy functions – Sure. Probably FaceArtifacts in artifacts.py and the others in geometry.py?
  • small demo data – Any other ideas? Maybe @anastassiavybornova has a nice idea?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants