Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing for geometry.angle_between_two_lines() #24

Merged
merged 4 commits into from
Oct 5, 2024
Merged

testing for geometry.angle_between_two_lines() #24

merged 4 commits into from
Oct 5, 2024

Conversation

jGaboardi
Copy link
Collaborator

This MR:

@jGaboardi jGaboardi self-assigned this Oct 5, 2024
@jGaboardi jGaboardi mentioned this pull request Oct 5, 2024
Closed
5 tasks
@jGaboardi jGaboardi marked this pull request as ready for review October 5, 2024 17:47
@jGaboardi jGaboardi requested a review from martinfleis October 5, 2024 17:47
martinfleis
martinfleis reviewed Oct 5, 2024
View reviewed changes
sgeop/geometry.py Outdated Show resolved Hide resolved
sgeop/geometry.py Outdated Show resolved Hide resolved
@jGaboardi
Copy link
Collaborator Author

geometry.angle_between_two_lines() is deep in the code base. Leaving the warning at stacklevel=2 for now, but probably should update later.

@martinfleis
Copy link
Contributor

It may actually pop at different stacklevels do 2 is good.

@jGaboardi
Copy link
Collaborator Author

It may actually pop at different stacklevels do 2 is good.

So are we good to merge or do you still need to review?

@martinfleis martinfleis merged commit 199f20c into main Oct 5, 2024
8 checks passed
@martinfleis martinfleis deleted the GH20_geometry_tests branch October 5, 2024 20:40
@jGaboardi jGaboardi mentioned this pull request Oct 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinfleis martinfleis martinfleis approved these changes

Assignees

@jGaboardi jGaboardi

Labels
refactor & code maint tests/CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

public objects in geometry.py?
2 participants
@jGaboardi @martinfleis