Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add initial card images #75

Merged
merged 3 commits into from
Feb 20, 2024

Conversation

beersandrew
Copy link
Contributor

Ran cards generation script with --image-width 512, this locks the width to 512, however for some more elongated shapes it still produces large images, not sure if there's a better strategy there, I suppose there could be some math the make the longest side fit to the input width.

Many test assets had empty card images so i didn't commit them

@meshula
Copy link
Contributor

meshula commented Jan 31, 2024

I notice ElephantWithMonochord is empty ~ I wonder why?

I do think it would be good to go with maximum dimension instead of strictly width.

@beersandrew
Copy link
Contributor Author

I notice ElephantWithMonochord is empty ~ I wonder why?

This bounding box for the elephant has always been off. I think I have a version that is fixed, but I have to double check, maybe that's a separate PR?

I do think it would be good to go with maximum dimension instead of strictly width.

Okay, I'll update the script for this

@meshula
Copy link
Contributor

meshula commented Feb 2, 2024

If you have a fix for the elephant's bounds that would be a great separate PR :)

@beersandrew
Copy link
Contributor Author

If you have a fix for the elephant's bounds that would be a great separate PR :)

Improved elephant PR: #76

- make sure the image width is the maximum dimension of the image rather than strictly the width
- fixing card images that had dimensions larger than 512 pixels
@beersandrew
Copy link
Contributor Author

I do think it would be good to go with maximum dimension instead of strictly width.

committed a fix for this, let me know what you think.

Copy link
Contributor

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the enormous images to be 512 tall :) looking good

@jcowles jcowles merged commit e713e6e into usd-wg:main Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants