-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use gost API endpoints in FFE email notification #4000
Draft
TylerHendrickson
wants to merge
6
commits into
main
Choose a base branch
from
feat/arpa-exporter/reporter-endpoint-in-email
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Use gost API endpoints in FFE email notification #4000
TylerHendrickson
wants to merge
6
commits into
main
from
feat/arpa-exporter/reporter-endpoint-in-email
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QA SummaryView the workflow summary for individual coverage reports if this comment is truncated.
Test CoverageCoverage report for `packages/client`
Coverage report for `packages/server`
|
Terraform Summary
Hint: If "Terraform Format & Style" failed, run OutputValidation Output
Plan Summary
Pusher: @TylerHendrickson, Action: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket #3908
Description
This PR updates the arpa-exporter email notification, replacing the single presigned S3 URL for the zip file with a gost API URL. This adds an additional measure of security, ensuring that users must be authenticated with the ARPA Reporter tool before downloading an S3-hosted file. It also includes an additional link in the email notification that allows users to download the accompanying metadata CSV.
Additionally, this PR addresses
# TODO
comments inarpa-exporter/src/worker.py
by refactoring theUploadInfo
model in the following ways:directory_location
field topath_in_zip
Finally, a new endpoint handler is added to the ARPA reporter API, at
/api/exports/:tenantId/getFullFileExport/:downloadType(archive|metadata)
. When this endpoint receives an authenticated request, a presigned URL is generated for the requested object and a redirect is issued to the client to download the file as an attachment. This endpoint corresponds to the links provided to the user in the arpa-exporter email notification.