Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github action is pushing to dockerhub under wrong tag for develop #214

Open
MishkaMN opened this issue Jan 10, 2024 · 0 comments
Open

github action is pushing to dockerhub under wrong tag for develop #214

MishkaMN opened this issue Jan 10, 2024 · 0 comments
Assignees
Labels
anomaly Something isn't working

Comments

@MishkaMN
Copy link
Contributor

MishkaMN commented Jan 10, 2024

Summary

There are two minor issues in the github action in this repo:

on:
  push:
    branches:
      - "develop"
      - "master"
jobs:
  docker:
    runs-on: ubuntu-latest
    steps:
      - name: Checkout
        uses: actions/checkout@v3
      - name: Set up Docker Buildx
        uses: docker/setup-buildx-action@v2
      - name: Login to DockerHub
        uses: docker/login-action@v2
        with:
          username: ${{ secrets.DOCKERHUB_USERNAME }}
          password: ${{ secrets.DOCKERHUB_TOKEN }}

      - name: Build and Push carma-messenger-ui Docker Image
        uses: docker/build-push-action@v3
        with:
          context: ./carma-messenger-ui/
          push: true
          tags: usdotfhwastoldev/carma-messenger-ui:${{ github.ref_name }}-carma-messenger-ui         

      - name: Build and Push carma-messenger-core Docker Image
        uses: docker/build-push-action@v3
        with:
          context: ./carma-messenger-core/
          push: true
          tags: usdotfhwastoldev/carma-messenger-core:${{ github.ref_name }}-carma-messenger-core       

      - name: Build and Push chevrolet_tahoe_2018 Docker Image
        uses: docker/build-push-action@v3
        with:
          context: ./carma-messenger-config/chevrolet_tahoe_2018/
          push: true
          tags: usdotfhwastoldev/carma-messenger-config:${{ github.ref_name }}-chevrolet_tahoe_2018  

      - name: Build and Push development Docker Image
        uses: docker/build-push-action@v3
        with:
          context: ./carma-messenger-config/development/
          push: true
          tags: usdotfhwastoldev/carma-messenger-config:${{ github.ref_name }}-development    
  1. The configuration is triggering push for usdotfhwastoldev docker org on master merges. master is for release
  2. usdotfhwastoldev/carma-messenger-ui:develop-carma-messenger-ui and usdotfhwastoldev/carma-messenger-core:develop-carma-messenger-core are wrong image tags. Correct tags just have develop
    usdotfhwastoldev/carma-messenger-ui:develop and usdotfhwastoldev/carma-messenger-core:develop

Version

4.3.0 (Current)

Expected Behavior

See above

Actual Behavior

See above

Steps to Reproduce the Actual Behavior

See above

Related Work

No response

@MishkaMN MishkaMN added the anomaly Something isn't working label Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
anomaly Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants