Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UC3 Convert SPaT to DPP Exception in dpp_generator #268

Open
1 of 3 tasks
Saeid-Solei opened this issue Nov 29, 2022 · 0 comments
Open
1 of 3 tasks

UC3 Convert SPaT to DPP Exception in dpp_generator #268

Saeid-Solei opened this issue Nov 29, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@Saeid-Solei
Copy link
Collaborator

Types of Issue

  • Anomaly report (something appears to not work correctly)
  • Enhancement request (describe the enhancement being requested)
  • Other (please ensure the description clarifies why the issue doesn’t fall into either of the above categories)

Descriptive summary

desired_phase_plan_generator has a method called convert_spat_to_dpp which converts the movement_event list in spat to a desired_phase_plan. This method will go through all possible movement groups and check if the movement_event list in spat contains green movement_states with the same start and end time for all signal groups included in a movement group. Now, if a movement group contains more than 1 signal group (e.g., movement group 1: [signal group 1, signal group 5]), but the movement_event list in spat has green movement_states for only one of the signal groups (e.g., signal group 1 is green from timestamp x to timestamp y, but signal group 5 is not green from timestamp x to timestamp y), then the convert_spat_to_dpp method will not add this movement group to the converted desired plan. This is the intended behavior, but the method does not log any statement to inform the operator about this case or throws any exception. This issue is created to add log statement and exception for this case.

Carma streets version where this issue was discovered

4.2.0

Expected behavior

Actual behavior

Steps to reproduce the actual behavior

Related work

@Saeid-Solei Saeid-Solei added the enhancement New feature or request label Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant