Merge branch 'usebruno:main' into feature/support-for-generating-Powe…

…rShell-code
usebruno · Feb 13, 2024 · 78dc7e3 · 78dc7e3
2 parents 8e6f2a0 + 3c87c1d
commit 78dc7e3
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/contributing.md b/contributing.md
@@ -28,10 +28,6 @@ You would need [Node v18.x or the latest LTS version](https://nodejs.org/en/) an
 
 Bruno is being developed as a desktop app. You need to load the app by running the Next.js app in one terminal and then run the electron app in another terminal.
 
-### Dependencies
-
-- NodeJS v18
-
 ### Local Development
 
 ```bash

diff --git a/packages/bruno-app/src/components/RequestTabs/RequestTab/ConfirmRequestClose/index.js b/packages/bruno-app/src/components/RequestTabs/RequestTab/ConfirmRequestClose/index.js
@@ -12,6 +12,7 @@ const ConfirmRequestClose = ({ item, onCancel, onCloseWithoutSave, onSaveAndClos
       disableEscapeKey={true}
       disableCloseOnOutsideClick={true}
       closeModalFadeTimeout={150}
+      handleCancel={onCancel}
       onClick={(e) => {
         e.stopPropagation();
         e.preventDefault();

diff --git a/packages/bruno-electron/src/ipc/network/prepare-request.js b/packages/bruno-electron/src/ipc/network/prepare-request.js
@@ -15,11 +15,12 @@ const parseFormData = (datas, collectionPath) => {
       const filePaths = value || [];
       filePaths.forEach((filePath) => {
         let trimmedFilePath = filePath.trim();
+
         if (!path.isAbsolute(trimmedFilePath)) {
           trimmedFilePath = path.join(collectionPath, trimmedFilePath);
         }
-        const file = fs.readFileSync(trimmedFilePath);
-        form.append(name, file, path.basename(trimmedFilePath));
+
+        form.append(name, fs.createReadStream(trimmedFilePath), path.basename(trimmedFilePath));
       });
     } else {
       form.append(name, value);