Merge pull request #857 from snippetkid/855-fix-yup-schema-validation

Address validation issue in Yup schema
usebruno · Nov 2, 2023 · b633fc5 · b633fc5
2 parents 9cf8a58 + 09d6bc8
commit b633fc5
Showing 1 changed file with 11 additions and 8 deletions.
diff --git a/packages/bruno-app/src/components/Sidebar/NewRequest/index.js b/packages/bruno-app/src/components/Sidebar/NewRequest/index.js
@@ -38,14 +38,17 @@ const NewRequest = ({ collection, item, isEphemeral, onClose }) => {
             return !['collection', 'folder'].includes(trimmedValue);
           }
         }),
-      curlCommand: Yup.string()
-        .min(1, 'must be at least 1 character')
-        .required('curlCommand is required')
-        .test({
-          name: 'curlCommand',
-          message: `Invalid cURL Command`,
-          test: (value) => getRequestFromCurlCommand(value) !== null
-        })
+      curlCommand: Yup.string().when('requestType', {
+        is: (requestType) => requestType === 'from-curl',
+        then: Yup.string()
+          .min(1, 'must be at least 1 character')
+          .required('curlCommand is required')
+          .test({
+            name: 'curlCommand',
+            message: `Invalid cURL Command`,
+            test: (value) => getRequestFromCurlCommand(value) !== null
+          })
+      })
     }),
     onSubmit: (values) => {
       if (isEphemeral) {