pr #1184: addressed review comments

usebruno · Dec 14, 2023 · ee2295a · ee2295a
1 parent 2d16e07
commit ee2295a
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/packages/bruno-app/src/components/ResponsePane/ResponseClear/index.js b/packages/bruno-app/src/components/ResponsePane/ResponseClear/index.js
@@ -2,15 +2,14 @@ import React from 'react';
 import { IconEraser } from '@tabler/icons';
 import { useDispatch } from 'react-redux';
 import StyledWrapper from './StyledWrapper';
-import { responseReceived } from 'providers/ReduxStore/slices/collections/index';
+import { responseCleared } from 'providers/ReduxStore/slices/collections/index';
 
 const ResponseClear = ({ collection, item }) => {
   const dispatch = useDispatch();
-  const response = item.response || {};
 
   const clearResponse = () =>
     dispatch(
-      responseReceived({
+      responseCleared({
         itemUid: item.uid,
         collectionUid: collection.uid,
         response: null
@@ -19,7 +18,7 @@ const ResponseClear = ({ collection, item }) => {
 
   return (
     <StyledWrapper className="ml-2 flex items-center">
-      <button onClick={clearResponse} disabled={!response.dataBuffer} title="Clear response">
+      <button onClick={clearResponse} title="Clear response">
         <IconEraser size={16} strokeWidth={1.5} />
       </button>
     </StyledWrapper>

diff --git a/packages/bruno-app/src/providers/ReduxStore/slices/collections/index.js b/packages/bruno-app/src/providers/ReduxStore/slices/collections/index.js
@@ -269,6 +269,16 @@ export const collectionsSlice = createSlice({
         }
       }
     },
+    responseCleared: (state, action) => {
+      const collection = findCollectionByUid(state.collections, action.payload.collectionUid);
+
+      if (collection) {
+        const item = findItemInCollection(collection, action.payload.itemUid);
+        if (item) {
+          item.response = null;
+        }
+      }
+    },
     saveRequest: (state, action) => {
       const collection = findCollectionByUid(state.collections, action.payload.collectionUid);
 
@@ -1397,6 +1407,7 @@ export const {
   processEnvUpdateEvent,
   requestCancelled,
   responseReceived,
+  responseCleared,
   saveRequest,
   deleteRequestDraft,
   newEphemeralHttpRequest,