Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#352): Variable interpolation for multipart form body #1217

Conversation

Its-treason
Copy link
Member

@Its-treason Its-treason commented Dec 13, 2023

  • Moved creation of FormData object into interpolation phase
  • BREAKING CHANGE: This means in the pre-request-script req.body is no longer the FormData object, instead it's a plain key value object (See Input Body in the second screenshot).

Closes: #352


App:
grafik

Cli:
grafik

- Moved creation of FormData object into interpolation phase
  - BREAKING: This means that one can no longer access FormData directly
    in the pre-request script, instead the body is now an object.
@Its-treason Its-treason force-pushed the bugfix/multipart-form-variable-interpolation branch from 48779f7 to 8848da1 Compare December 13, 2023 21:46
@Its-treason Its-treason changed the title fix: Variable interpolation for multipart form body fix(#352): Variable interpolation for multipart form body Dec 13, 2023
@ARESBAN
Copy link

ARESBAN commented Jan 29, 2024

How's it going?

@blured75
Copy link

Any progress on that ? Could be nice to have :)

@Fabrice-Deshayes-aka-Xtream

Hello. I'm interested in this fix. Any idea when it will be merged?

@Andreas-Schoenefeldt
Copy link
Contributor

@helloanoop, it would be awesome to have this in the codebase - the bug is super annoying.

@Its-treason
Copy link
Member Author

I fixed the Merge conflicts. I'm not sure about the changes to all the README's i think those are made by prettier.

@mariomka
Copy link

Is there any progress on that? Can I help in any manner? It blocks us from moving from Insomnia to Bruno :S

@Andreas-Schoenefeldt
Copy link
Contributor

Hi @mariomka, it is usually best to contact @helloanoop in Discord.

@xosealvarez
Copy link

Any updates?

@Its-treason
Copy link
Member Author

Any updates?

Not yet, I also need to fix merge conflicts, when this is allowed to be merged.

For now, you can download my fork, that includes this and some other merge requests, but is still 100 percent compatible with normal bruno: https://github.com/Its-treason/bruno/releases/tag/nightly

@xosealvarez
Copy link

Hi @Its-treason, your fork works really good, well done, thanks a lot

@Schoof-T
Copy link

Any updates? :) Still waiting on this before I can fully switch to Bruno!

@chriswinter90
Copy link

This is a problem for us also. I suppose we could disable the 20 or so tests for now that require this with our project but definitely a pain point.

@mleziva
Copy link

mleziva commented May 6, 2024

We are also waiting for this fix

@Andreas-Schoenefeldt
Copy link
Contributor

I think it is already good in the latest version of Bruno - it might have been fixed by some other ticket. At least my collections are not running, but I had to enter the variables fresh after update.

@xosealvarez
Copy link

xosealvarez commented May 8, 2024

I think it is already good in the latest version of Bruno - it might have been fixed by some other ticket. At least my collections are not running, but I had to enter the variables fresh after update.

I tried this with the latest version and the issue continues, It's not solved yet. (Version 1.16.1)

@end3rbyte
Copy link
Contributor

@helloanoop This PR definitely needs to be merged, many people are waiting on it.
Could we please move forward with it ?

@Andreas-Schoenefeldt
Copy link
Contributor

Andreas-Schoenefeldt commented May 15, 2024

I did another ping on this topic in the Discord Bugs Channel - It is at least on the radar again 🤞.

@helloanoop helloanoop requested review from lohxt1 May 15, 2024 10:43
@helloanoop
Copy link
Contributor

@Its-treason Thank you so much for your work on this.

This effort is now being tracked at #3142
We plan to have support for variable interpolation in multipart form merged and released next week.

Closing this PR.

@helloanoop helloanoop closed this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Variables in the body with multipat form type.