-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(#352): Variable interpolation for multipart form body #1217
fix(#352): Variable interpolation for multipart form body #1217
Conversation
- Moved creation of FormData object into interpolation phase - BREAKING: This means that one can no longer access FormData directly in the pre-request script, instead the body is now an object.
48779f7
to
8848da1
Compare
How's it going? |
Any progress on that ? Could be nice to have :) |
Hello. I'm interested in this fix. Any idea when it will be merged? |
@helloanoop, it would be awesome to have this in the codebase - the bug is super annoying. |
I fixed the Merge conflicts. I'm not sure about the changes to all the README's i think those are made by prettier. |
Is there any progress on that? Can I help in any manner? It blocks us from moving from Insomnia to Bruno :S |
Hi @mariomka, it is usually best to contact @helloanoop in Discord. |
Any updates? |
Not yet, I also need to fix merge conflicts, when this is allowed to be merged. For now, you can download my fork, that includes this and some other merge requests, but is still 100 percent compatible with normal bruno: https://github.com/Its-treason/bruno/releases/tag/nightly |
Hi @Its-treason, your fork works really good, well done, thanks a lot |
Any updates? :) Still waiting on this before I can fully switch to Bruno! |
This is a problem for us also. I suppose we could disable the 20 or so tests for now that require this with our project but definitely a pain point. |
We are also waiting for this fix |
I think it is already good in the latest version of Bruno - it might have been fixed by some other ticket. At least my collections are not running, but I had to enter the variables fresh after update. |
I tried this with the latest version and the issue continues, It's not solved yet. (Version 1.16.1) |
@helloanoop This PR definitely needs to be merged, many people are waiting on it. |
I did another ping on this topic in the Discord Bugs Channel - It is at least on the radar again 🤞. |
@Its-treason Thank you so much for your work on this. This effort is now being tracked at #3142 Closing this PR. |
req.body
is no longer theFormData
object, instead it's a plain key value object (SeeInput Body
in the second screenshot).Closes: #352
App:
Cli: