-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(generate-code): fixing generate code issue where headers from collections are not being reflected #1246
fix(generate-code): fixing generate code issue where headers from collections are not being reflected #1246
Conversation
…lections are not being reflected
@helloanoop can you please check this when you get time, will this be the correct way to go about this ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, I just looked over your merge request, and it's not quite right.
You are using the headers from item.requestSent.headers
but this is only set after sending a request.
The collection headers are stored in collection.root.request.headers
and can be merged with the normal request headers. I added some code suggestion, with my idea.
...o-app/src/components/Sidebar/Collections/Collection/CollectionItem/GenerateCodeItem/index.js
Outdated
Show resolved
Hide resolved
...o-app/src/components/Sidebar/Collections/Collection/CollectionItem/GenerateCodeItem/index.js
Outdated
Show resolved
Hide resolved
...o-app/src/components/Sidebar/Collections/Collection/CollectionItem/GenerateCodeItem/index.js
Outdated
Show resolved
Hide resolved
@Its-treason thanks for the review. The only reason I wanted to stick with items was to make sure any new additions do not cause this piece to break again. But given that we only have collections for now, I think this is a good idea. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I just saw this PR has been merged: #1316 that does the same thing as this PR.
So This PR might be obsolete, sorry I put you through the hassle of making review changes, I should have seen the other PR earlier
Closing this pull request as another one fixing the bug had already been merged. Thank you for taking the time to address the issue!! |
# Description
This PR fixes the generate code issue where headers from collections are not being reflected upon generating code
Fixes: #1245
Contribution Checklist:
Issue Video:
bruno_issue.mov
Resolution Video:
bruno_issue_solution.mov