FIX: Request>Auth>Bearer configuration does not override if Collection>Auth>Basic is set.

[karloluis]

Description

Fixes #1536 and #960

The way axios handles the auth property on the request configurations makes it such that it will always take precedence over the headers.authorization for the headers object. This was causing issues where the Bruno Collection has Basic Auth and the Request being run has Bearer Auth.

Reproducing

1. In Collection>Settings>Auth select Basic
2. In a Request>Auth select Bearer
3. Spin up an http server; preferably with a debugger and a breakpoint on the endpoint
4. Inspect the req.headers property the server received

This will result in Basic ========; in this fix it should be Bearer =======

Alternative implementation

Instead of inverting logic and doing conditional validations consider potentially mutating the request object.
By doing delete request.auth on the condition for the request on bearer mode the bug can be avoided. Although I tend to shy away from mutating objects this way as it may have unintended side-effects.

Contribution Checklist:

• The pull request only addresses one issue or adds one feature.
• The pull request does not introduce any breaking changes
• I have added screenshots or gifs to help explain the change if applicable.
• I have read the contribution guidelines.
• Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

[karloluis]

Best read in split diff view.

[karloluis]

Added tests and hoping for feedback to polish it further.

[karloluis]

Appears to be fixed by #1667