Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#1033): Add possibility to prompt for variables #1558

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

KoljaTM
Copy link

@KoljaTM KoljaTM commented Feb 9, 2024

Description

bru.prompt(varName, prompt) allows to specify variables that should be prompted in a pre- or post-request script

This is my first contribution to bruno, so I hope I got the implementation in accordance with the way things are supposed to be done. I am open to suggestions, e.g. if there would be a better way to implement this features or which kinds of test to include.

Contribution Checklist:

  • [X ] The pull request only addresses one issue or adds one feature.
  • [ X] The pull request does not introduce any breaking changes
  • [ X] I have added screenshots or gifs to help explain the change if applicable.
  • [ X] I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.
image
image

- bru.prompt(varName, prompt) allows to specify variables that should be prompted in a pre- or post-request script
@mjhcorporate
Copy link
Contributor

I love this idea! Have you thought of a corresponding implementation for the cli?

@bSolt
Copy link

bSolt commented Apr 10, 2024

Can you add an option to make the prompted variable secret like for a standard html password input then bruno would save the var as type: secret?

@helloanoop helloanoop self-assigned this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants