fix(#263): Implement script- & test-runtime in node:vm #1565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its-treason
force-pushed
the
bugfix/node-vm
branch
from
84f340a to
7912e10
Compare
Due to changes in usebruno#650 collection variables would be passed as a object but was exptected to be an array. Collection variables are now converted to an array.
Its-treason
force-pushed
the
bugfix/node-vm
branch
from
9bc11f1 to
e528a2f
Compare
|
is it possible that we can get this merged? |
|
@helloanoop is there anything I can do to get this one merged in? |
|
@helloanoop @lohxt1 is it possible to prioritise review of this pull request to help unblock our team ? If you can share timelines when your team will be able review will also help us plan migrate to Bruno. Cc: @Its-treason |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #263 & #922
Implemented the existing script- & test-runtime with
node:vmto deprecatevm2. All runtimes are now combined in one file / function, because the other three runtimes before shared a lot of same code.If you want to test this locally, you have to manually activate the runtime by changing the hard-coded
if (false)to true, so it uses the new runtime.Test collection for anyone wanting to try / test it:
https://cdn.discordapp.com/attachments/1036297730483564687/1227724527752974336/VM-Test.zip?ex=66297291&is=6616fd91&hm=63637d55a57c17b3b2fff3ca34d9b17bdcd0deb734a0d685f64b17bab21bd464&