Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Stop button for runner execution #1580

Merged
merged 8 commits into from
Feb 13, 2024

Conversation

rsilvr
Copy link
Contributor

@rsilvr rsilvr commented Feb 13, 2024

Description

  • Added a stop button to stop a runner execution before it finishes
  • This implementation uses the same event logic of request cancellation
  • As CancelToken API is deprecated in Axios, I migrated the request cancellation code to use the AbortController API

image
image

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Closes #143
Closes #1444

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

@rsilvr rsilvr marked this pull request as ready for review February 13, 2024 16:13
@helloanoop helloanoop merged commit 942a895 into usebruno:main Feb 13, 2024
2 of 3 checks passed
@helloanoop
Copy link
Contributor

This is great!

Thank you @rsilvr !
Appreciate the effort in to move away from CancelToken and use AbortController api.

@rsilvr rsilvr deleted the feat/stop-runner branch February 13, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not stop collection run after initiation Collection Runner Improvements
2 participants