Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: accessibility issue on the Welcome page #1906

Closed
wants to merge 1 commit into from
Closed

fix: accessibility issue on the Welcome page #1906

wants to merge 1 commit into from

Conversation

shrilakshmishastry
Copy link
Contributor

@shrilakshmishastry shrilakshmishastry commented Mar 23, 2024 •
edited
Loading

Description

Fix accessibility issues on the Welcome page:

  • use button tag for collection instead of div
  • hide decorative images for assistive technology
  • give meaningful labels to links in the Links section

Accessibility tree structure

then now
Screenshot 2024-03-23 at 10 30 44 AM Screenshot 2024-03-23 at 10 41 30 AM

issue link : accessibility issue

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

@shrilakshmishastry
fix: accessibility issue in Welcome page
12c9957 
  - use button tag for collection instead of div
  - hide decorative image for assistive technology
  - give meaningful label to links in Links section
@shrilakshmishastry shrilakshmishastry changed the title fix: accessibility issue in Welcome page fix: accessibility issue on the Welcome page Mar 23, 2024
@shrilakshmishastry shrilakshmishastry mentioned this pull request Mar 25, 2024
Closed
@Pragadesh-45 Pragadesh-45 mentioned this pull request Sep 23, 2024
Merged
4 tasks
@helloanoop
Copy link
Contributor

Thanks @shrilakshmishastry for your work on this.
We made some updates on top of your PR and it has been merged as a part of #3173

@helloanoop helloanoop closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Pragadesh-45 Pragadesh-45

Labels
pr-refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shrilakshmishastry @helloanoop @Pragadesh-45 @sanjai0py