Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bru-rmvar): add bru.rmVar(varType, key) command #2472

Closed
wants to merge 1 commit into from
Closed

feat(bru-rmvar): add bru.rmVar(varType, key) command #2472

wants to merge 1 commit into from

Conversation

bpoulaindev
Copy link
Contributor

Description

Referencing issue #2464

Add a new bru.rmVar() command that helps replicate pm.environment.unset()

The command is recognized in the UI and can edit content from envVariables, collectionVariables and also processEnvVars.
How to use : bru.rmVar([varType], [key])

image image

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

@bpoulaindev
Copy link
Contributor Author

bpoulaindev commented Jun 17, 2024

The commands #1714 are also interesting, and considering those are simple and necessary, while the PR is more than 3 months old is crazy

@martinsefcik
Copy link
Contributor

If there are setVar/getVar and setEnvVar/getEnvVar methods why not to have rmVar and rmEnvVar?
In my eyes it is better as to introduce some weird and long varType strings which will be error prone because of typos during typing it.

@helloanoop
Copy link
Contributor

Thank for taking time to work on this @bpoulaindev

Bruno now supports bru.deleteVar() which was implemented as a part of another PR
Closing this PR.

@helloanoop helloanoop closed this Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants