Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/close-all-tabs #2975

Closed
wants to merge 2 commits into from
Closed

Conversation

panda7789
Copy link
Contributor

@panda7789 panda7789 commented Aug 30, 2024

Description

Fixes #2965
Closing of NotFound tab not working, because code was accessing item.draft property that doesnt exist and also it was in try catch so error was not thrown 😄

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Before:
https://github.com/user-attachments/assets/1d494dc4-9b3b-408f-ad56-30ec2ed1559e

After:
https://github.com/user-attachments/assets/cb738a7b-b1bd-4aa1-bac0-cbe0efe51447

@helloanoop helloanoop self-assigned this Sep 22, 2024
@Pragadesh44-Bruno
Copy link
Collaborator

Hey @panda7789,

Thanks for raising this PR. I think these changes make sense to include. However, I’ve tested this, and these changes won’t fix the issue mentioned above. Could you update the PR description?

@panda7789
Copy link
Contributor Author

I think it was solved with #3192
when "Not found" tab is not possible anymore.

@panda7789 panda7789 closed this Jan 17, 2025
@Pragadesh44-Bruno
Copy link
Collaborator

@panda7789 Yes, you're right. We have fixed the issue with "Not Found" tabs being displayed when rename or move actions are performed. However, in some cases, "Not Found" tabs are still appearing. We'll look into it for a proper fix. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Close all does not close all tabs
4 participants