Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Enable back comment toggling for JSON in request body editor #3807

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ramki-bruno
Copy link
Collaborator

@ramki-bruno ramki-bruno commented Jan 15, 2025

Initially Implemented in #2634 and regressed on #3462
Closes #1451

Description

Enable back comment toggling for JSON in request body editor.
This maps both Cmd+/ and Ctrl+/ for toggling-comment.

Screen.Recording.2025-01-15.at.8.34.32.PM.mov

@helloanoop
Copy link
Contributor

Unsure why the CLI tests are failing here in the publish test report step (strangely it passes in other PRs).
I tried re-running them 3 times to no avail.

@ramki-bruno
Copy link
Collaborator Author

Unsure why the CLI tests are failing here in the publish test report step (strangely it passes in other PRs). I tried re-running them 3 times to no avail.

I think its failing for all the branches created directly on the repo.

@ramki-bruno
Copy link
Collaborator Author

ramki-bruno commented Jan 16, 2025

Looks like its failing for all the merge commits as well.
So, it failing at Publish Test Report step for all the commits on this repo.
Probably lacking access to write the test-report?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comment with keybinding (cmd + /)
3 participants