fix:handle render svg response #3833
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sreelakshmi-bruno
requested review from
naman-bruno
and removed request for
sanjai0py
naman-bruno
suggested changes
Jan 30, 2025
| }else if (contentType.includes('image')) { | ||
| return 'application/image'; | ||
| } | ||
| else if (contentType.includes('xml')) { |
There was a problem hiding this comment.
@sahell0x Could you please adjust the formatting in this PR? Everything else looks great!
| @@ -88,7 +88,6 @@ const QueryResult = ({ item, collection, data, dataBuffer, width, disableRunEven | |||
| } else if (contentType.includes('video')) { | |||
| allowedPreviewModes.unshift({ mode: 'preview-video', name: 'Video', uid: uuid() }); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Can you revert this change as well
| @@ -92,7 +92,10 @@ export const getContentType = (headers) => { | |||
| return header[1]; | |||
| }); | |||
| if (contentType && contentType.length) { | |||
| if (typeof contentType[0] == 'string' && /^[\w\-]+\/([\w\-]+\+)?json/.test(contentType[0])) { | |||
| if (typeof contentType[0] === 'string' && /^image\/svg\+xml/i.test(contentType[0])) { | |||
| return 'image/svg+xml'; | |||
There was a problem hiding this comment.
The formatting needs to be adjusted here as well.
There was a problem hiding this comment.
@naman-bruno latest commits are here please review .
This reverts commit e007227.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
issue ticket : #3781
i have added functionality to handle image/svg+xml contentType in getContentType function previously it is treating image/svg + xml as application/xml that is not allowing it to render on ui, now user can see image preview as well raw.
in getCodeMirrorModeBasedOnContentType i moved image condition to before the xml to handle both seamlessly .
Contribution Checklist:
Publishing to New Package Managers
Please see here for more information.