[DX]: Document running test suite for all workspaces #4095
+57
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
todo, add to all other languages contributing guides
|
Looks good. @pieterocp ! |
|
Thanks, feel free to slap an approval and merge it whenever. |
pieterocp
force-pushed
the
add-all-test-to-contributing
branch
from
4e6f14d to
0ddb715
Compare
|
Put in machine translations, for the 3 languages I do know it's decent enough, for the others, complete shot in the dark. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a developer who hasn't worked on many npm projects using workspaces, I wasn't aware how npm has the ability to run a command over all the workspaces . This means with this one-liner, a developer can easily run nearly all of the test suites in one go.
So off the back of this, this PR changes the contributing documentation slightly to make it clearer it's possible to run the tests over the whole project rather than having to run them one by one.
Note, once I get a thumbs up emoji/an affirmative comment that is a welcomed change, then I'll make the change to all the different languages using auto-translation tools to amend the
# run tests over all workspacescomments into respective languages.Contribution Checklist: