Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: about bruno window crash #4123

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pooja-bruno
Copy link
Collaborator

@pooja-bruno pooja-bruno commented Feb 27, 2025

Description

Addressing issue: #4040, #4120

This PR fixes issue with the About window that was causing it to crash. The window was failing to load properly due to Content Security Policy (CSP) restrictions that blocked inline scripts.

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.
image

callback({
responseHeaders: {
...details.responseHeaders,
'Content-Security-Policy': ["default-src 'self'; script-src 'self' 'unsafe-inline'; style-src 'self' 'unsafe-inline';"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pooja-bruno are you sure we need all these CSPs to make it work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants