Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat (#485) : close tabs on middle mouse click #586

Closed

Conversation

Sahilm416
Copy link

=> feat #485
=> onMouseUp event is added at tabs
=> tabs close on middle mouse click
=> warning is shown for drafted work (unsaved)

@Sahilm416
Copy link
Author

Sahilm416 commented Oct 14, 2023

@helloanoop as you and @martinsefcik said i have done all the changes . thanks for the previous reviews !

@helloanoop helloanoop added this to the v2 milestone Oct 18, 2023
@helloanoop
Copy link
Contributor

Will be taking a look at this post our 1.0.0 release that is scheduled for Oct 28th - #643

@kpau
Copy link

kpau commented Nov 13, 2023

@helloanoop, I know that currently you are overwhelmed, but this seems like a low-complexity issue. Any chance to move it forward soon?
Thanks!

@IceBjerg
Copy link

Please merge this 🙏 It is giving me a headache that I cannot close tabs with middle click 🤣

@BorisGerretzen
Copy link

I would also really appreciate this, it's one of the main things I'm missing right now.

@Gabrielcefetzada
Copy link
Contributor

Gabrielcefetzada commented Feb 22, 2024

This pull request code is with an issue when user attemps to close a tab with draft changes

close-problem

I adapted this feature to the current Bruno code and opened a new PR -> check here

@helloanoop
Copy link
Contributor

Thank you for your work on this @Sahilm416 !

This functionality was merged in #1649

This will be available in the release v1.10.0 that will be shipped today.

cc @kpau @IceBjerg @BorisGerretzen !

@helloanoop helloanoop closed this Feb 27, 2024
@Sahilm416
Copy link
Author

Thanks @helloanoop and @Gabrielcefetzada for this one✨
This was my first contribution to Bruno and you guys really helped me through it....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants