-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat (#485) : close tabs on middle mouse click #586
Conversation
@helloanoop as you and @martinsefcik said i have done all the changes . thanks for the previous reviews ! |
Will be taking a look at this post our 1.0.0 release that is scheduled for Oct 28th - #643 |
@helloanoop, I know that currently you are overwhelmed, but this seems like a low-complexity issue. Any chance to move it forward soon? |
Please merge this 🙏 It is giving me a headache that I cannot close tabs with middle click 🤣 |
I would also really appreciate this, it's one of the main things I'm missing right now. |
This pull request code is with an issue when user attemps to close a tab with draft changes I adapted this feature to the current Bruno code and opened a new PR -> check here |
Thank you for your work on this @Sahilm416 ! This functionality was merged in #1649 This will be available in the release |
Thanks @helloanoop and @Gabrielcefetzada for this one✨ |
=> feat #485
=> onMouseUp event is added at tabs
=> tabs close on middle mouse click
=> warning is shown for drafted work (unsaved)