Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort by number of commits ahead instead of stars #70

Closed

Conversation

devnoname120
Copy link
Contributor

@devnoname120 devnoname120 commented Nov 15, 2024

@payne911
Copy link
Collaborator

I don't think I'd merge this given it's a rather arbitrary change.
I would rather love to see #48 appropriately addressed as it would allow the needed flexibility.

@payne911 payne911 closed this Nov 30, 2024
@devnoname120
Copy link
Contributor Author

What do you mean with arbitrary? I consistently get more useful results with number of commits. Highly starred forks are routinely abandoned too and the successors can take years before reaching the same number of stars.

@payne911
Copy link
Collaborator

But the high amount of stars at least guarantee that the (potentially few) changes that were made were actually very much appreciated by the community.
Whereas I see tons of people forking repos, and doing a bunch of useless changes to Readme.md just to seemingly gather higher commit counts on their GitHub profile... probably in hope to boost their resume?

Anyhow, again: the best way forward is to implement a generic sorting functionality :)

@devnoname120
Copy link
Contributor Author

devnoname120 commented Dec 3, 2024

Well to be honest I haven't seen this to be an issue within the context of this tool. Useless changes to README.md rarely make it to the top. You can have 10 useless commits, but rarely a hundred. On the other hand, the issue that this pull request resolves is something I stumble upon almost every time I perform a search.

While I agree that implementing a generic sorting functionality would be nice it's a lot more work. Also IMO it doesn't necessarily make reconsidering the choice of defaults outdated. As far as I'm concerned the change suggested in this pull request solves 99% of the problem for me. Not a hill I want to die on though, I will just maintain my fork if it's not merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants