Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine workflows for creating preview and publishing content into one workflow #39

Closed
wants to merge 4 commits into from

Conversation

arash77
Copy link
Collaborator

@arash77 arash77 commented Jun 12, 2024

This PR combines the workflows for creating preview and publishing content into one workflow.

Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok to me!

@arash77
Copy link
Collaborator Author

arash77 commented Jun 13, 2024

This also covers #36

Copy link
Member

@wm75 wm75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this be a use case for composite actions to make the env and branch setup reusable across the two existing workflows?

Would seem like the cleaner approach to me that would allow for the two workflows to diverge more in the future.

@arash77
Copy link
Collaborator Author

arash77 commented Jun 13, 2024

Thank you @wm75, Using composite actions seems to be a better idea. I will later work on that.

@arash77
Copy link
Collaborator Author

arash77 commented Jun 13, 2024

I will then close this PR to work on that approach soon.

@arash77 arash77 closed this Jun 13, 2024
@arash77 arash77 mentioned this pull request Jun 14, 2024
@arash77 arash77 deleted the combine-workflows branch June 19, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants