Feature: add lagoon-core version to build payload #3260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
uselagoon/build-deploy-tool#85 is to track consuming this in the build-deploy-tool |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
As #3257 describes, sending the lagoon-core version in builds could be very useful for builds to be able to consume.
This PR uses a scope of
internal_systemto injectLAGOON_SYSTEM_CORE_VERSIONwhich is not able to be defined in the API by users, it is only used by internal systems and is a simple way to pass variables/values from core to builds without having to change CRDs or other resources. Builds are be able to consume these without fear that a user will have changed them.Closing issues
closes #3257