-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #4257 fixed ui for mermaid diagrams in dark mode #4289
base: main
Are you sure you want to change the base?
Conversation
@X1Vi , by forcing dark mode light mode now has the issue dark mode had. Are you able to set the values dynamically based on the user settings? |
When you select Have a look here to see how this has been handled in the past |
Can you elaborate more as to what you want exactly ? because if it is |
@X1Vi , there are 3 theme options
When you select My suggestion was to either
@johnnyjoygh added a 3rd option of using the |
…llow system' is selected
@johnnyjoygh I have made a new and better solution I wasn't completely aware that how the theme works completely (Didn't knew there was another hook as well). I have selected themes which I sought suitable if you feel like they are not suitable then feel free to ping me. I think we will have to just adjust the themes. |
fixes #4257
The diagrams are now visible and can be seen easily in dark mode