Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle malformed config.json #43

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

semperos
Copy link
Member

@semperos semperos commented Apr 5, 2024

Returning None when the config doesn't parse causes the later configuration validation print the intended error message instructing the user to check the config.json file.

This also prints the error from json.load to stderr

Copy link

This pull request has been linked to Shortcut Story #264539: User Error: Malformed config.json.

pivotal-import/lib.py Outdated Show resolved Hide resolved
Returning None when the config doesn't parse causes the later
configuration validation print the intended error message instructing
the user to check the config.json file.

This also prints the error from json.load to stderr
@semperos semperos force-pushed the daniel/sc-264539/user-error-malformed-config-json branch from 2df3105 to 0eebf9a Compare April 5, 2024 04:09
@semperos semperos requested a review from opoku April 5, 2024 04:10
@semperos semperos merged commit ac6876f into main Apr 5, 2024
2 checks passed
@semperos semperos deleted the daniel/sc-264539/user-error-malformed-config-json branch April 5, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants